Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.23.2 #4726

Merged
merged 6 commits into from
Nov 25, 2024
Merged

release: 0.23.2 #4726

merged 6 commits into from
Nov 25, 2024

Conversation

davidhewitt
Copy link
Member

Staging branch for the 0.23 release series so that I can cherry-pick onto it without getting worried about the state of main.

We probably want to have merged:

... and I'd also potentially want MutexExt and RwLockExt traits as per PyO3/rust-numpy#471 (comment), but those could also wait for a future release.

dependabot bot and others added 3 commits November 22, 2024 16:49
* Bump codecov/codecov-action from 4 to 5

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* format ci yml

* fix "file" -> "files" deprecation

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Hewitt <[email protected]>
* add `IntoPyObjectExt` trait

* adjust method names, more docs & usage internally

* more uses of `IntoPyObjectExt`

* guide docs

* newsfragment

* fixup doctest

* Update guide/src/conversions/traits.md

Co-authored-by: Icxolu <[email protected]>

---------

Co-authored-by: Icxolu <[email protected]>
@davidhewitt
Copy link
Member Author

The above fixes are merged; I will update the branch and ship this tonight.

@bschoenmaeckers
Copy link
Contributor

I would love to see #4708 included as well if that is possible.

@davidhewitt
Copy link
Member Author

Yep that's my plan 👍

LilyFoote and others added 3 commits November 25, 2024 18:59
* Add test for ambiguous associated item

The `#[pyclass]` macro implements `IntoPyObject` for the annotated enum.
When the enum has any of `Error`, `Output` or `Target` as members, this
clashes with the associated types of `IntoPyObject`.

This also happens when deriving `IntoPyObject` directly.

* Fix #4723: ambiguous associated item in #[pyclass]

This uses the fix described in rust-lang/rust#57644

Also apply fix to `#[derive(IntoPyObject)]`.
* update build config logic and library name generation

* fix free-threaded windows clippy with --features=abi3

* use constant

* add release note

* apply my self-review comments

* use ensure and error handling instead of panicking

* skip abi3 fixup on free-threaded build

* don't support PYO3_USE_ABI3_FORWARD_COMPATIBILITY on free-threaded build

* don't panic in pyo3-ffi in abi3 check

* document lack of limited API support

* add is_free_threaded() method to InterpreterConfig

* implement David's code review suggestions

* remove unused imports
@davidhewitt davidhewitt marked this pull request as ready for review November 25, 2024 22:15
@davidhewitt davidhewitt merged commit a967826 into release-0.23 Nov 25, 2024
76 checks passed
@davidhewitt davidhewitt deleted the release-0.23.2 branch November 25, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants