Dev/keithley2100 #3
Conversation
Update commands. Refractor lines and whitespace.
Refactor Keithley2100VISADriver initialization and method calls
…_plugins_keithley into dev/keithley2100
…modaq_plugins_keithley into dev/keithley2100
…modaq_plugins_keithley into dev/keithley2100
…modaq_plugins_keithley into dev/keithley2100
…modaq_plugins_keithley into dev/keithley2100
Co-authored-by: Amelie Francoise Deshazer <[email protected]>
Dev/keithley2100
…modaq_plugins_keithley into dev/keithley2100
|
Keithley2100 is fixed and ready to be reviewed again. |
Add suggestion
| @@ -152,22 +112,20 @@ def grab_data(self, Naverage=1, **kwargs): | |||
| =============== ======== =============================================== | |||
|
|
|||
| """ | |||
| logger.info("grab_data called") | |||
There was a problem hiding this comment.
maybe add it as debug (not info) because it will be printed a lot on your log file which as the INFO level by default
| "limits": resources_list, | ||
| "value": resources_list[0], | ||
| "type": "str", | ||
| "value": rsrc_name, |
There was a problem hiding this comment.
where is the rsrc_name defined? I only say a type declaration line 11?
| ], | ||
| ) | ||
|
|
||
| self.dte_signal.emit(dte) | ||
|
|
||
| def stop(self): | ||
| """Stop the current grab hardware wise if necessary""" | ||
| self.emit_status(ThreadCommand("Update_Status", ["Acquisition stopped"])) | ||
| return "" | ||
| raise NotImplemented |
There was a problem hiding this comment.
Do not raise the error otherwise you'll have issue... just return the empty string
| DataFromPlugins( | ||
| name="K2100", data=data, dim="Data0D", labels=["dat0", "data1"] | ||
| ) | ||
| DataFromPlugins(name="K2100", data=data, dim="Data0D", labels=["dat0", "data1"]) |
There was a problem hiding this comment.
the data attribute should be a list of numpy array. is that the case from the data = self.controller.read() line?
There was a problem hiding this comment.
Is there two channels? The number of elements in labels should reflect this with appropriate names!
| # resolution = 6 | ||
| # nplc = 5 | ||
|
|
||
| [Keithley.2100] |
There was a problem hiding this comment.
don't you use those configuration?
Add Multimeter Keithley 2100 to pymodaq_plugins_keithley. Add keithley2100_VISADriver and daq_0Dviewer_Keithley2100.