-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed "interactive" arg from cli.py #23
base: main
Are you sure you want to change the base?
Conversation
Update forked main branch
I have some other quick questions @bbelderbos
|
Good catches, that seems all redundant now so can be removed. Thanks |
- version number control is now in pyproject.toml
Driver path used to be controlled by Selenium
- Did not know the best way to access version from pyproject.toml file
Removed driver-path argument in cli.py, carbon_main_.py and README. Initially removed Maybe use importlib.metadata or tomli? Or probably best to leave as is for now. |
thanks, |
Removed mentions of interactive mode in Selenium