Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "interactive" arg from cli.py #23

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

cmsato09
Copy link
Contributor

Removed mentions of interactive mode in Selenium

@cmsato09
Copy link
Contributor Author

I have some other quick questions @bbelderbos

  • carbon/init.py file has __version__. Better to remove it since 'version' is now controlled in pyproject.toml?
  • "--driver-path" argument in cli.py was previously controlled by the DRIVER_PATH variable in the .env file? Since the .env file has been removed, should this argument also be removed?

@bbelderbos
Copy link
Collaborator

Good catches, that seems all redundant now so can be removed. Thanks

- version number control is now in pyproject.toml
Driver path used to be controlled by Selenium
- Did not know the best way to access version from pyproject.toml file
@cmsato09
Copy link
Contributor Author

Removed driver-path argument in cli.py, carbon_main_.py and README.

Initially removed __version__ from init.py, but didn't know the best way to access it from pyproject.toml, so re-added it back in. Still need it for the "-v", "--version" option to work.

Maybe use importlib.metadata or tomli? Or probably best to leave as is for now.
https://stackoverflow.com/questions/73902812/how-can-use-the-version-specified-in-pyproject-toml-file-in-my-python-typer-pr

@bbelderbos
Copy link
Collaborator

thanks, metadata would be good and you don't need the try/except because we're on >= 3.10 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants