-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve PHP SDK notices for PHP 8.2 #217
Comments
That didn't work. It said the patch files were invalid when trying to apply them on composer install. Also, that was still tedious and not ideal. |
Should probably just fork https://github.com/Asana/php-asana and include it in the build pipeline with our own branch of fixes. Aye yi yi... So it'd be added as a git submodule that needs to be built rather than a simple composer dependency. Sigh... |
Apply patch file in the build script after composer dependencies are installed.
See Asana/php-asana#119 (comment) for a start on this.
There are
#[\ReturnTypeWillChange]
deprecation notices coming fromvendor/nategood/httpful/src/Httpful/Response/Headers.php
and#[\AllowDynamicProperties]
coming from Asana's PHP SDK.Eventually, we may need to switch to our own custom class implementation for working with the Asana API due to the lack of activity in the official PHP SDK.
The text was updated successfully, but these errors were encountered: