Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve PHP SDK notices for PHP 8.2 #217

Closed
MichelleBlanchette opened this issue Apr 27, 2024 · 2 comments · Fixed by #224
Closed

Resolve PHP SDK notices for PHP 8.2 #217

MichelleBlanchette opened this issue Apr 27, 2024 · 2 comments · Fixed by #224
Assignees
Labels
cleanup Improves code organization and usability

Comments

@MichelleBlanchette
Copy link
Collaborator

Apply patch file in the build script after composer dependencies are installed.

See Asana/php-asana#119 (comment) for a start on this.

There are #[\ReturnTypeWillChange] deprecation notices coming from vendor/nategood/httpful/src/Httpful/Response/Headers.php and #[\AllowDynamicProperties] coming from Asana's PHP SDK.

Eventually, we may need to switch to our own custom class implementation for working with the Asana API due to the lack of activity in the official PHP SDK.

@MichelleBlanchette MichelleBlanchette added the cleanup Improves code organization and usability label Apr 27, 2024
@MichelleBlanchette MichelleBlanchette self-assigned this Apr 27, 2024
@MichelleBlanchette
Copy link
Collaborator Author

MichelleBlanchette commented Apr 28, 2024

This has good information on how to generate and apply patches via Composer itself: https://tomasvotruba.com/blog/2020/07/02/how-to-patch-package-in-vendor-yet-allow-its-updates

That didn't work. It said the patch files were invalid when trying to apply them on composer install. Also, that was still tedious and not ideal.

@MichelleBlanchette
Copy link
Collaborator Author

Should probably just fork https://github.com/Asana/php-asana and include it in the build pipeline with our own branch of fixes. Aye yi yi... So it'd be added as a git submodule that needs to be built rather than a simple composer dependency. Sigh...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improves code organization and usability
Projects
None yet
1 participant