Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix procedural generation of random systems. #273

Open
se5a opened this issue Mar 7, 2020 · 1 comment
Open

Fix procedural generation of random systems. #273

se5a opened this issue Mar 7, 2020 · 1 comment

Comments

@se5a
Copy link
Contributor

se5a commented Mar 7, 2020

They should be using a pseudo random generator to create the systems, but I don't think the systems are coming out the same each time.
Some work may need to be done to inspect the systems a bit easier (I think currently you may be able to hit escape and go into SM mode, then scroll the map all the way out, and select another system - if that's not broken)
Tests should also be written to check that a seed will give the same result each time.

@DifferentLevelDan
Copy link
Contributor

I believe procedural generation is working fine. CreateAndCheckDeterministic can and does create the same system twice. We do have issues with it because we're not checking 100% of the DataBlobs due to issue #381 , but it does check some and they create the same thing each time. I'd like to leave this open until we can confirm after issue #381 is resolved.

DifferentLevelDan added a commit that referenced this issue Nov 3, 2023
PR updated, does not fully resolve #381 Expanded the reflection. Determined Mineral Generation is currently Non-Deterministic. See also: #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants