Updated Video embed modal to support oEmbed data #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue #348 - Video embed now treats video embed as a 1:1 pointer to provider video oEmbed data. URL field is no longer editable after being saved, since changing the URL would be the same as removing the video and adding a new one. - Added drag-and-drop support for video URL's into Video embed modal via plain text (dragged from address bar) or link HTML (dragged from link to video URL). - Added support for promises to be returned by embedType's getModelFromForm method.
- All private methods should now be function statements instead of vars.
Issue #348 - Using Vimeo oEmbed API to support option their extened options and prevent mangling of mulitbyte characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #348