Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed template markup should not contain hard-coded image references #354

Open
rpeterman-gp opened this issue Feb 1, 2017 · 1 comment
Assignees

Comments

@rpeterman-gp
Copy link
Contributor

Slideshow template contains:
<div class="slideshow_editor-slide_image js-slide_image" style="background-image:url(https://test-services.pri.org/image/2016/05/13/b2e0f83b63414f74a21d8a4fdb9d5328/Prince_We_World_web.jpg)"><img src="https://test-services.pri.org/image/2016/05/13/b2e0f83b63414f74a21d8a4fdb9d5328/Prince_We_World_web.jpg"></div>

GlobalBuzz template contains:
<img class ="buzz-field-quote-png" src="http://www.pri.org/sites/all/themes/pri/images/icon-open-quote.png">

All templates should be evaluated and have these types of URL's cleaned. If they are theme related, they should be moved to a CSS style of some type.

@brandonhundt
Copy link
Member

For the quote use: /theme/images/icon-open-quote.png

rpeterman-gp added a commit that referenced this issue Feb 2, 2017
- GlobalBuzz quote image should be styled by platform-admin CSS to
prevent images from having to be packaged by embed-containers.
rpeterman-gp added a commit that referenced this issue Feb 2, 2017
Issue #354 - Removed hard-coded template URL's
rpeterman-gp added a commit that referenced this issue Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants