Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External link embed HTML should not contain elements for missing fields #351

Open
rpeterman-gp opened this issue Nov 3, 2016 · 0 comments
Open

External link embed HTML should not contain elements for missing fields #351

rpeterman-gp opened this issue Nov 3, 2016 · 0 comments
Assignees
@rpeterman-gp
Labels
bug P3 (Low)

Comments

@rpeterman-gp
Copy link
Contributor

Reproduce

  1. Open embed modal to insert an External Link embed.
  2. Fill in required fields and Save.

Epected

Embed should only show a link button with link text.

Currently

Embed shows empty image, 'NULL' Display Title, and 'null' teaser text, along with the link button.
@rpeterman-gp rpeterman-gp self-assigned this Nov 3, 2016
rpeterman-gp added a commit that referenced this issue Nov 3, 2016
@rpeterman-gp
Updated External Link embed modal
e09b5e5 
Issue #351
- Updated embed HTML generated for editor to contain elements for fields
that have values.
- Added drag-and-drop support to External Link embed modal for image
field, similar to Image embed.
- Updated embed types that support file uploads to use file URL returned
from API and not assume and force an assumed domain.
rpeterman-gp added a commit that referenced this issue Nov 4, 2016
@rpeterman-gp
Embeds with files get api domain from api service
104e925 
- Issue #351 - Updated CSS styles for External Links embed to work with
new embed template markup.
- Fixed issue with parent.initModal
@rpeterman-gp rpeterman-gp mentioned this issue Nov 4, 2016
Merged
rpeterman-gp added a commit that referenced this issue Feb 28, 2017
@rpeterman-gp
BUILD 2017.02.28-001
457f1cc 
Issues #348, #349, #351, #354
@rpeterman-gp rpeterman-gp mentioned this issue Feb 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpeterman-gp rpeterman-gp

Labels
bug P3 (Low)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpeterman-gp