Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Identity usign a string #620

Open
riveign opened this issue Oct 3, 2022 · 3 comments
Open

Import Identity usign a string #620

riveign opened this issue Oct 3, 2022 · 3 comments
Assignees

Comments

@riveign
Copy link
Collaborator

riveign commented Oct 3, 2022

Description

Since we can import an account using the PEM files, we want to offer the option of importing using the string inside the PEM.

The user should be able to:

  • Input a string to import an account
  • If the string is valid the account should be imported
  • If the string is not valid the account should not be imported
  • This can be only done inside of the application / extension not on the import wallet flow

Designs: https://www.figma.com/file/no61f8MMPQlPUIaXSX3zCn/Plug---Wallet?node-id=10687%3A12435

@alinasytnik
Copy link
Collaborator

alinasytnik commented Nov 25, 2022

⚠️Bug

Description

Show the error message if the account has already been imported or created.

Steps to Reproduce

  1. Open Plug
  2. Create a wallet
  3. Click on the Emoji in a left top corner
  4. Click on Import Wallet
  5. Click on Import Private Key
  6. Try to add already created/imported account
    Current: Notice that the user can add the already imported/created account.

Expected behavior

The "Account already added" message should be shown.

Screenshots

Screen.Recording.2022-11-25.at.16.24.20.mov

Device characteristics (please complete the following information):

  • Device: Macbook
  • OS: iOS
  • Version: 0.6.2

@alinasytnik alinasytnik reopened this Nov 25, 2022
@alinasytnik
Copy link
Collaborator

⚠️Bug

Description

Validation for Private Key input.

Steps to Reproduce

  1. Open Plug
  2. Create a wallet
  3. Click on the Emoji in a left top corner
  4. Click on Import Wallet
  5. Click on Import Private Key
  6. Fill the Private Key input with random symbols
    Current: Notice that Continue button id able to click.

Expected behavior

Add the validation to the Import Private Key input. The user shouldn't be able to click on the Continue button if private key doesn't meet the rules.

Screenshots

Screen.Recording.2022-11-25.at.17.31.58.mov

Device characteristics (please complete the following information):

  • Device: Macbook
  • OS: iOS
  • Version: 0.6.2

@alinasytnik
Copy link
Collaborator

alinasytnik commented Nov 28, 2022

QA approved ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants