Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resolve package versions from lockfile #77

Open
regevbr opened this issue May 9, 2020 · 0 comments
Open

feat: resolve package versions from lockfile #77

regevbr opened this issue May 9, 2020 · 0 comments
Labels
feature Add new feature

Comments

@regevbr
Copy link
Contributor

regevbr commented May 9, 2020

Currently, we use the semver in package.json to resolve the version to check, but if a lock file exists (yarn/npm) we need to respect it instead.
We can levrage https://github.com/snyk/nodejs-lockfile-parser for the task.
We should also probably allow the user to skip that resolving method.
@regevbr regevbr added the feature Add new feature label May 9, 2020
@regevbr regevbr changed the title feature: resolve package versions from lockfile feat: resolve package versions from lockfile May 9, 2020
@stale stale bot added the wontfix This will not be worked on label Jul 8, 2020
@PruvoNet PruvoNet deleted a comment from stale bot Jul 9, 2020
@stale stale bot removed the wontfix This will not be worked on label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Add new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@regevbr