Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Use noble-ed25519 instead of tweetnacl for signature verification #16

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

larabr
Copy link

@larabr larabr commented Jun 26, 2024

Faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite it being smaller, because it relies on bigint literals, and it requires polyfilling the WebCrypto lib manually in Node < 19.

Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
@larabr larabr merged commit d23eff7 into ProtonMail:v6 Jun 26, 2024
9 of 12 checks passed
larabr added a commit that referenced this pull request Jul 5, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Sep 5, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Sep 9, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Sep 9, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Sep 11, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Nov 6, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Nov 22, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
larabr added a commit that referenced this pull request Nov 22, 2024
Much faster than tweetnacl, and no constant-timeness required.

We are not using v2 for now, despite being smaller, because it relies on
bigint literals, and it requires polyfilling the WebCrypto lib
manually in Node < 19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants