BasicOrder Memory Reuse
#54
Conversation
Avoid copying spent items and received items from memory to memory for restricted orders when one is calling the zone's `authorizeOrder` and `validateOrder` instead populate the data in the memory region before and after the spend items and received items used for the `OrderFulfilled`'s event data.
| ptr = getFreeMemoryPointer(); | ||
| // Derive offset to pre `OrderFulfilled`'s spent item event data | ||
| // using base offset & total original recipients. | ||
| ptr = MemoryPointer.wrap( |
There was a problem hiding this comment.
this could be unchecked; if totalOriginalAdditionalRecipients is big enough to overflow the addition or zero out the shift, then it'd fail the hash derivation that goes down prior to reaching here
There was a problem hiding this comment.
fixed it in the next commit.
| unchecked { | ||
| // Derive offset to pre `OrderFulfilled`'s spent item event data | ||
| // using base offset & total original recipients. | ||
| ptr = MemoryPointer.wrap( |
There was a problem hiding this comment.
note for myself: The original eventDataPtr is @ OrderFulfilled_baseOffset=0x200 + BasicOrder_totalOriginalAdditionalRecipients_cdPtr * 0x20. Here we go to authorizeOrder_calldata_baseOffset=0x80 + BasicOrder_totalOriginalAdditionalRecipients_cdPtr * 0x20. So we're 0x180 in front of it, which is what we want.
| * the layout of that event data changes. | ||
| * and encodes it as `authorizeOrder` calldata. Note that memory data is reused | ||
| * from `OrderFulfilled` event data, and the rest of the calldata is prefixed and | ||
| * postfixed to this memory region. Importantly the memory region before the |
There was a problem hiding this comment.
Importantly the memory region before the
OrderFulfilled's spent and received items are overwritten
why is it safe to do that? @Saw-mon-and-Natalie
Avoid copying spent items and received items from memory to memory for restricted orders when one is calling the zone's
authorizeOrderandvalidateOrderinstead populate the data in the memory region before and after the spend items and received items used for theOrderFulfilled's event data.