Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

31: Add parameter relations to protocol for workflows. #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lfse-slafleur
Copy link
Member

No description provided.

@lfse-slafleur lfse-slafleur self-assigned this Nov 27, 2024
@lfse-slafleur lfse-slafleur marked this pull request as ready for review November 27, 2024 16:04
@@ -51,10 +51,25 @@ message WorkflowParameter {
}
}

message ParameterRelation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments by Cheng-Kai and myself: Project-OMOTES/orchestrator#83 (review)

Suggestion to rename to ParameterConstraint and only have 1 other_parameter.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or ref_parameter_key_name (more explicit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add variable conditional relations in workflow definition including smaller and greater than
3 participants