Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Add option for server only version #4

Open
Cleptomania opened this issue Oct 11, 2023 · 1 comment
Open

Assembler: Add option for server only version #4

Cleptomania opened this issue Oct 11, 2023 · 1 comment

Comments

@Cleptomania
Copy link
Member

No description provided.

@Cleptomania
Copy link
Member Author

The option is there now, though it needs fleshed out a bit more. Right now it just ignores client side mods(this has some conflict with the caching of mod downloads though, if a client only mod is cached, and you don't force download, it will be included).

Downloading mods from CurseForge makes this kind of annoying to deal with because of having to dynamically fetch the filename from the Curse API. To deal with this in the GitHub actions build I just do the server build first, so that it doesn't have a mod download cache. There could technically be server only mods included, but there aren't right now, and I doubt there will be.

Probably not worth making that better until either we have nothing being downloaded from curseforge directly(unlikely) or we have a better caching system(intermediate self-hosted cache that can be manually triggered to update as needed? Only really needed for the Curse mods, pulling JARs from Github is fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant