[Bug]: Villagers names on trading tab not translated

[ffuentesm]

What happened?
Would be nice to fix this long string name for their proper name.

Minecraft Version: 1.20.1
Ice and Fire version: iceandfire 2.1.13-1.20.1+build.beta-2
EMI trade: forge-1.2.1

[Flamarine]

does ice & fire itself provide translation of this profession? if not then it's an issue of ice & fire's side.

[ffuentesm]

I asked them about this problem first, as I assume is their problem since other moded villagers have no problem in their names, but they said: AlexModGuy/Ice_and_Fire#5091 (comment)

So I posted here just in case.

[Flamarine]

hmm, seems like this profession's translation key does not follow what is expected by emi trades.
honestly i don't know how i can fix this on my side, as other villagers do follow the expected translation key format (which does not expect the modid but only the name), meaning i'll have to make a hardcode fix for this (which is bad and meaningless and thus something i don't really want to do)
i'll left this open tho to see what i may do in the future.

[ffuentesm]

hum...
I think they are just using an outdated translation key, as they just updated from 1.16.5 to 1.20.1.
And maybe JEP just hardcodes the translation.

[Flamarine]

i see. might look into this later.
but i cannot touch my device in the next few days so you may need to wait for a while

[ffuentesm]

Hum, I had a similar problem in IE villagers, and it seems the translation key has a discrepancy of :
instead of entity.minecraft.villagers.mod_id.name
it uses entity.minecraft.villagers.mod_id:name as well as entity.minecraft.villagers.name

[Cicopath]

Old ticket, but I just discovered that another mod. [Let's Do] BeachParty, does something similar:

Yet, in the Jade entity UI on the top of a player's screen and the EMI Trades UI, it uses entity.minecraft.villager.beach_guy instead of entity.minecraft.villager.beachparty.beach_guy

EDIT: other [Let's Do] mods actually have both translations: entity.minecraft.villager.[mod ID].[villager profession] and entity.minecraft.villager.[villager profession]