Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small things in the Register method #3

Open
shutterbug2000 opened this issue Oct 11, 2021 · 2 comments · May be fixed by #4
Open

Various small things in the Register method #3

shutterbug2000 opened this issue Oct 11, 2021 · 2 comments · May be fixed by #4

Comments

@shutterbug2000
Copy link

It seems the string() function is outputting either a pointer of some kind, or the int as raw data. Either way, it doesn't output the port as normal text.

I only noticed it by comparing packets from Nintendo's server and this one (while working on another game's server).
Whether it will cause issues? I'm not sure. Just figured I'd bring it up :p

This is the line I'm referring to:
https://github.com/PretendoNetwork/super-mario-maker-secure/blob/34b4475429545b8c3396a5eece10f0dafcbb699d/register.go#L12

@shutterbug2000
Copy link
Author

This might cause issues too (setting the response method as RegisterEx, while responding to Register)

https://github.com/PretendoNetwork/super-mario-maker-secure/blob/34b4475429545b8c3396a5eece10f0dafcbb699d/register.go#L29

@shutterbug2000 shutterbug2000 changed the title Register doesn't convert the port to a string correctly Various small things in the Register method Oct 12, 2021
@jonbarrow
Copy link
Member

Do you wanna open a quick PR? Or I can just change these things manually

@shutterbug2000 shutterbug2000 linked a pull request Oct 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants