[NEW UI] Check wording parts 1 #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tblivet
commented
Nov 28, 2024
tblivet
commented
| Questions | Answers |
|---|---|
| Description? | Check wording (first session) for already functional parts |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | @PrestaShopCorp |
| How to test? | - |
| 'message' => $this->translator->trans('The "/admin/autoupgrade" directory isn\'t writable. Provide write access to the user running PHP with appropriate permission & ownership.'), | ||
| 'message' => $this->translator->trans( | ||
| 'The %s directory isn\'t writable. Provide write access to the user running PHP with appropriate permission & ownership.', | ||
| [$this->autoUpgradePath] |
There was a problem hiding this comment.
Is the path displayed is sanitized? We should make sure the actual admin folder is not displayed to keep the merchants data safe in case he makes a screenshot of this page.
There was a problem hiding this comment.
Ok, so we should go with /your-admin-directory/autoupgrade/ ?
There was a problem hiding this comment.
Yep, one good way would be to use the sanitizer currently present in the Logger class.
Co-authored-by: Thomas N <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.