Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP error message sometimes not propagated #292

Closed
1 task
mitchnielsen opened this issue Oct 29, 2024 · 0 comments
Closed
1 task

HTTP error message sometimes not propagated #292

mitchnielsen opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mitchnielsen
Copy link
Contributor

mitchnielsen commented Oct 29, 2024

Summary

While testing #289, I noticed that I wasn't getting the HTTP error message back - just the response code:

Plan: 1 to add, 0 to change, 0 to destroy.
prefect_deployment.deployment: Creating...
prefect_deployment.deployment: Still creating... [10s elapsed]
╷
│ Error: Error creating deployment
│
│   with prefect_deployment.deployment,
│   on main.tf line 42, in resource "prefect_deployment" "deployment":
│   42: resource "prefect_deployment" "deployment" {
│
│ Could not create deployment, unexpected error: http error: Post
│ "https://api.stg.prefect.dev/api/accounts/9a67b081-4f14-4035-b000-1f715f46231b/workspaces/85bad5d0-48ee-42be-9f72-8a2998512d85/deployments/":
│ POST
│ https://api.stg.prefect.dev/api/accounts/9a67b081-4f14-4035-b000-1f715f46231b/workspaces/85bad5d0-48ee-42be-9f72-8a2998512d85/deployments/
│ giving up after 5 attempt(s)

This appears to be related to #286, where the retryable HTTP client we use appears to be swallowing the error.

References

Acceptance criteria

  • When HTTP-related errors are encountered, the related message is printed out in the Terraform logs
@mitchnielsen mitchnielsen added the bug Something isn't working label Oct 29, 2024
@parkedwards parkedwards self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants