Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Hardcoded Login Credentials From Webscrapers #10

Open
3 tasks
abhiramtilakiiit opened this issue Oct 30, 2023 · 2 comments
Open
3 tasks
Assignees
Labels
bug Something isn't working

Comments

@abhiramtilakiiit
Copy link
Collaborator

abhiramtilakiiit commented Oct 30, 2023

Current status:

  • When building the webscapers, some temporary accounts were created to test them.
  • The credentials for the temporary accounts are publically being displayed.
  • This could lead to huge security issues.

Proposed changes:

TO DO:

  • Create a simple script which takes the credentials as input
  • Remove the current credentials and remove the temporary accounts associated with it.
  • Update related Documentation
@abhiramtilakiiit abhiramtilakiiit added the bug Something isn't working label Oct 30, 2023
@PraneethJain
Copy link
Owner

We can replace the credentials with fake ones and direct the user to fill in the username and password that they want?

@abhiramtilakiiit
Copy link
Collaborator Author

Nah, just take standard input would be UI friendly. You can still direct the user to fill in the username and password in the documentation btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants