Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latests updates on 5.x branch #1299

Closed
edwinheij opened this issue Dec 18, 2023 · 6 comments
Closed

latests updates on 5.x branch #1299

edwinheij opened this issue Dec 18, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@edwinheij
Copy link
Contributor

Have you searched through other issues to see if your problem is already reported or has been fixed?

Yes, I did not find it.

Did you read the documentation?

Yes, I did not find it.

Have you tried to publish the views?

Yes - I didn't work.

Is there an error in the console?

No

PHP Version

No response

PowerGrid

No response

Laravel

No response

Livewire

No response

Alpine JS

No response

Theme

Bootstrap

Describe the bug.

Tried to PR a JS update for TomSelect. Pulled the latest 5.x. After that searching was broken. For example when trying to search on 2 (text)fields only one (the first) was queried.
Think the last commits where you are updating the filters when wrong.
Hope you've got something about this issue.

To Reproduce...

Thank you for this wonderful package.

Extra information

<?php
 //...
@luanfreitasdev
Copy link
Member

luanfreitasdev commented Dec 18, 2023

Hi, can you give more details?

The version that worked, the version that didn't work. How are you using the feature?

@luanfreitasdev luanfreitasdev added the need more info Further information is requested label Dec 18, 2023
@edwinheij
Copy link
Contributor Author

Will create a repo for you.

@edwinheij edwinheij changed the title latests updates om 5.x branch latests updates on 5.x branch Dec 18, 2023
@edwinheij
Copy link
Contributor Author

Here's the repo which I made for you: https://github.com/edwinheij/livewire-powergrid-fail

  • user2-table is failing (this one is from the database)
  • user-table is working fine (from collection)

Repo install instructions:

git clone [email protected]:edwinheij/livewire-powergrid-fail.git
cd livewire-powergrid-fail
touch database/database.sqlite
php artisan migrate --seed

start website and filter both 'name' and 'email' from the first table. Only the first filter works.

@luanfreitasdev luanfreitasdev added bug Something isn't working and removed need more info Further information is requested labels Dec 18, 2023
@luanfreitasdev
Copy link
Member

Thank you!

Fixed. I will add some more tests

image

@luanfreitasdev
Copy link
Member

#1301

@luanfreitasdev
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants