refactor: Refactor snowflake to use spmc abstractions #26900
+140
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Refactor Snowflake batch export to use fully-async SPMC abstractions. Big part of the work was done in previous PRs, so there isn't much to do here.
Changes
SnowflakeConsumer
classSnowflakeConsumer
.SnowflakeConsumer
withrun_consumer_loop
in S3 batch export.file_no
fromSnowflakeHeartbeatDetails
(and associated tests). Since every consumer writes one file, we don't have a need to add afile_no
to each one. Every file name is unique asNamedTemporaryFile
generates a new name for each one.TODO:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Manually ran Snowflake unit tests, and everything passed (with the exception of the two tests that had to be fixed.