fix(batch-exports): Add InvalidS3EndpointError as a non-retryable error
#26895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgray
changed the title
InvalidS3EndpointError as a non-retryable error
rossgray
force-pushed
the
ross/batch-exports-non-retry-invalid-url
branch
from
0e94d32 to
fa05aae
Compare
tomasfarias
reviewed
Dec 13, 2024
| @@ -166,6 +166,13 @@ def __init__(self): | |||
| super().__init__("Endpoint URL cannot be empty.") | |||
|
|
|||
|
|
|||
| class InvalidS3EndpointError(Exception): | |||
There was a problem hiding this comment.
EmptyS3EndpointURLError is kind of redundant with this, maybe we should remove that and just raise InvalidS3EndpointError?
There was a problem hiding this comment.
yes, good point, will update
tomasfarias
approved these changes
Dec 13, 2024
rossgray
force-pushed
the
ross/batch-exports-non-retry-invalid-url
branch
from
1699713 to
e30991a
Compare
rossgray
force-pushed
the
ross/batch-exports-non-retry-invalid-url
branch
from
e30991a to
e7a5e89
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we retry a batch export if an invalid S3 endpoint was provided.
https://posthog.sentry.io/issues/5143259713/?project=4506225159897088&referrer=issue-stream&statsPeriod=7d&stream_index=0
Changes
Catch this particular error and raise a custom exception that we can treat as non-retryable.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
it doesn't have an impact
How did you test this code?
Added a test