Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-3001): fix tabs, error state, loading states #26881

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Dec 12, 2024

Problem

  • tabs get hidden when it passes the horizontal width
  • no loading state

Changes

  • make tabs scrollable
  • add insight loader component from insights
  • make sure when there's no query, don't fire an api call
  • show query time
  • don't reload between tabs

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@EDsCODE EDsCODE requested a review from Gilbert09 December 12, 2024 20:47
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@EDsCODE EDsCODE changed the title fix(editor-3001): make tabs scroll when overflowing fix(editor-3001): fix tabs, error state, loading states Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants