Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated remote config to include domain restrictions #26875

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: Updated remote config to include domain restrictions #26875

wants to merge 14 commits into from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 12, 2024 •
edited
Loading

Problem

We need a way to do some level of dynamic config checking

Changes

  • There is only one cached config entry now - the others are built in memory from that as they dont need other api calls
  • A domain can be passed as query param to check against for things like recordings
  • Add tests to ensure the api works as expected
  • Validate the CDN caches based on query params
  • Corresponding JS changes - feat: Added domain param to config requests posthog-js#1601

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review December 12, 2024 17:27
@benjackwhite benjackwhite requested a review from a team December 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverb123 oliverb123 oliverb123 approved these changes

@pauldambra pauldambra Awaiting requested review from pauldambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @oliverb123