feat(web-analytics): Allow customers to compare against a different period #26820
+325
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeelaudibert
commented
Dec 11, 2024
| @@ -882,6 +882,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([ | |||
| kind: NodeKind.WebExternalClicksTableQuery, | |||
| properties: webAnalyticsFilters, | |||
| dateRange, | |||
| compareFilter, // NOTE: Backend is not using this yet | |||
There was a problem hiding this comment.
@robbie-c Thoughts on whether this is actually helpful? Does it make sense to compare outbound link clicks? The backend doesn't compare it at all, it's always just current data
It's not hard to implement, but I'm trying to get a feeling here on how this could be helpful. I think it is, but I wanna hear from you.
There was a problem hiding this comment.
Yeah I think it is, but fine if we don't include it in this PR
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Base automatically changed from
display-stats-from-conversion-goals-only-2
to
master
December 11, 2024 16:08
…eriod Right now, we'd always compare our data against the last period, i.e. if we're looking at the data from the last 14 days, then you'd always compare it against the previous 14 days. This is not always ideal, as someone might want to compare against numbers from the same time last year. We've added the comparator component in a previous commit (hidden behind a FF) and we're now actually using that data in the backend.
Use same methods as we're using on `stats_table` to calculate previous metrics. We've extracted this up to `web_analytics_query_runner`
rafaeelaudibert
force-pushed
the
implement-comparison-to-complex-past-period
branch
from
7164e68 to
fd09fea
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
rafaeelaudibert
commented
Dec 12, 2024
There was a problem hiding this comment.
Come on buddy, why do you keep disappearing 😮💨
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
rafaeelaudibert
force-pushed
the
implement-comparison-to-complex-past-period
branch
from
3413f94 to
18ca9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Right now, we'd always compare our data against the last period, i.e. if we're looking at the data from the last 14 days, then you'd always compare it against the previous 14 days.
This is not always ideal, as someone might want to compare against numbers from the same time last year.
We've added the comparator component in a previous commit (hidden behind a FF) and we're now actually using that data in the backend.
Does this work well for both Cloud and self-hosted?
Yep
How did you test this code?