Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for the organization id #26515

Merged
merged 11 commits into from
Nov 29, 2024
Merged

Conversation

zlwaterfield
Copy link
Contributor

Changes

We have a % of users who's accounts are in a state where they belong to an organization but that organization have no projects. We also have a % of users with an account that belong to no organization.

Sentry: https://posthog.sentry.io/issues/6095311384/events/344f3e2f2c804baa88e0210afed06d15/?project=1899813&referrer=issue-list&statsPeriod=14d

This change does two things:

  • adds a check to the filters for access control to check for an organization
  • if the user loads the app with no organization, show a form instead of an error about projects

before
Screenshot 2024-11-28 at 11 54 15 AM

after:
Screenshot 2024-11-28 at 12 21 14 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

WIP - adding a few tests

@zlwaterfield zlwaterfield self-assigned this Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@zlwaterfield zlwaterfield merged commit 10add44 into master Nov 29, 2024
96 checks passed
@zlwaterfield zlwaterfield deleted the zach/fix-empty-team-org-id branch November 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants