empty state

PostHog · Dec 12, 2024 · 05ce85a · 05ce85a
1 parent e686c2e
commit 05ce85a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts b/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts
@@ -32,6 +32,7 @@ import {
     DashboardFilter,
     ErrorTrackingQuery,
     ErrorTrackingQueryResponse,
+    HogQLQuery,
     HogQLVariable,
     QueryStatus,
 } from '~/queries/schema'
@@ -174,6 +175,10 @@ export const dataNodeLogic = kea<dataNodeLogicType>([
                     const query = overrideQuery ?? props.query
                     const refresh = props.alwaysRefresh || refreshArg
 
+                    if (query.kind === NodeKind.HogQLQuery && !(query as HogQLQuery).query) {
+                        return null
+                    }
+
                     if (props.doNotLoad) {
                         return props.cachedResults
                     }

diff --git a/frontend/src/scenes/data-warehouse/editor/QueryWindow.tsx b/frontend/src/scenes/data-warehouse/editor/QueryWindow.tsx
@@ -1,5 +1,4 @@
 import { Monaco } from '@monaco-editor/react'
-import { Spinner } from '@posthog/lemon-ui'
 import { BindLogic, useActions, useValues } from 'kea'
 import { router } from 'kea-router'
 import type { editor as importedEditor } from 'monaco-editor'
@@ -87,16 +86,13 @@ export function QueryWindow(): JSX.Element {
     )
 }
 
-function InternalQueryWindow(): JSX.Element {
+function InternalQueryWindow(): JSX.Element | null {
     const { cacheLoading, sourceQuery, queryInput } = useValues(multitabEditorLogic)
     const { setSourceQuery } = useActions(multitabEditorLogic)
 
+    // NOTE: hacky way to avoid flicker loading
     if (cacheLoading) {
-        return (
-            <div className="flex-1 flex justify-center items-center">
-                <Spinner className="text-3xl" />
-            </div>
-        )
+        return null
     }
 
     const dataVisualizationLogicProps: DataVisualizationLogicProps = {