fix clang errors #21
Open
fix clang errors #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludflu
commented
Aug 4, 2024
ludflu
commented
- fix problems with casting unsigned ints to (void *) pointers
- these changes allow us to compile PortMidi for OSX again.
OlivierSohn
approved these changes
Aug 4, 2024
|
Is it possible to split commits into formatting and then actual fixing? |
|
yes, i'd be happy to do that |
|
Is there anything else I can do to help move this along? |
|
I am not familiar with this code at all, but after looking at how the descriptor field is used in the code base, the changes seem to be reasonable. I think I would prefer if the macro for casting is removed and casts are in the code directly. @dpwiz are you more familiar with this code base, what do you think? |
|
There were a few more warnings about pointers, so... #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.