Skip to content

Commit

Permalink
Bump version
Browse files Browse the repository at this point in the history
Signed-off-by: starry-shivam <[email protected]>
  • Loading branch information
starry-shivam committed Aug 12, 2023
1 parent d6a1efd commit d292bf5
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
6 changes: 2 additions & 4 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ android {
applicationId "com.starry.myne"
minSdk 26
targetSdk 34
versionCode 17
versionName "2.3.0"
versionCode 18
versionName "2.4.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables {
Expand Down Expand Up @@ -106,8 +106,6 @@ dependencies {
implementation "io.coil-kt:coil-compose:2.2.2"
// Room database components.
implementation "androidx.room:room-ktx:2.5.2"
implementation 'androidx.appcompat:appcompat:1.6.1'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
kapt "androidx.room:room-compiler:2.5.2"
androidTestImplementation "androidx.room:room-testing:2.5.2"
// Dagger - Hilt.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,12 @@ class ReaderActivity : AppCompatActivity(), ReaderClickListener {
val layoutManager = (binding.readerRecyclerView.layoutManager as LinearLayoutManager)

// Fetch data from intent.
val bookId = intent.extras?.getInt(EXTRA_BOOK_ID, DEFAULT_NONE)!!
val chapterIndex = intent.extras?.getInt(EXTRA_CHAPTER_IDX, DEFAULT_NONE)!!
val bookId = intent.extras?.getInt(EXTRA_BOOK_ID, DEFAULT_NONE)
val chapterIndex = intent.extras?.getInt(EXTRA_CHAPTER_IDX, DEFAULT_NONE)
isExternalBook = intent.type == "application/epub+zip"

// Internal book
if (bookId != DEFAULT_NONE) {
if (bookId != null && bookId != DEFAULT_NONE) {
// Load epub book from given id and set chapters as items in
// reader's recycler view adapter.
viewModel.loadEpubBook(bookId = bookId, onLoaded = {
Expand All @@ -206,7 +206,7 @@ class ReaderActivity : AppCompatActivity(), ReaderClickListener {
})
// if user clicked on specific chapter, then scroll to
// that chapter directly.
if (chapterIndex != DEFAULT_NONE) {
if (chapterIndex != null && chapterIndex != DEFAULT_NONE) {
layoutManager.scrollToPosition(chapterIndex)
}

Expand Down Expand Up @@ -236,7 +236,7 @@ class ReaderActivity : AppCompatActivity(), ReaderClickListener {
// reading progress into the database.
if (!isExternalBook) {
viewModel.updateReaderProgress(
bookId = bookId,
bookId = bookId!!,
chapterIndex = progressChIndex,
chapterOffset = progressChOffset
)
Expand Down
6 changes: 6 additions & 0 deletions fastlane/metadata/android/en-US/changelogs/18.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- Reworked on ebook reader backend, fixed scrolling lags and other stability improvements
- Added support for opening external EPUB files with inbuilt ebook reader.
- Added ability to jump between chapters inside the ebook reader.
- Updated target SDK to Android 14 (API 34)
- Made language selection persistent across app launches.
- Bug fixes and other improvements.

0 comments on commit d292bf5

Please sign in to comment.