From d83b1b69ca6e9078e16a4b0e40a93b41b0d70746 Mon Sep 17 00:00:00 2001
From: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
Date: Thu, 22 Aug 2024 17:03:56 +0200
Subject: [PATCH 1/4] feat: add version in about page (#256)

---
 src/routes/about/index.tsx | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/routes/about/index.tsx b/src/routes/about/index.tsx
index a1a4b7c6..dc2910ec 100644
--- a/src/routes/about/index.tsx
+++ b/src/routes/about/index.tsx
@@ -62,16 +62,19 @@ export const aboutRoute = new Route({
             </a>
           </div>
 
-          <div className="text-right">
-            Sviluppato con amore da{" "}
-            <a
-              target="_blank"
-              rel="noreferrer noopener"
-              href="https://polinetwork.org"
-            >
-              PoliNetwork
-            </a>{" "}
+          <div className="flex items-center justify-between">
+            <p className="opacity-60">Versione: {APP_VERSION}</p>
+            <p>
+              Sviluppato con amore da{" "}
+              <a
+                target="_blank"
+                rel="noreferrer noopener"
+                href="https://polinetwork.org"
+              >
+                PoliNetwork
+              </a>{" "}
             ❤️
+          </p>
           </div>
         </div>
       </Page>

From cdf9bb15e94179ebca77f56c10cdfb62e4aee122 Mon Sep 17 00:00:00 2001
From: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
Date: Thu, 22 Aug 2024 17:05:13 +0200
Subject: [PATCH 2/4] feat: close filter popover when clearing it (#257)

Co-authored-by: angeousta <132761637+angeousta@users.noreply.github.com>
---
 src/routes/viewer/Table/FilterBtn.tsx | 38 ++++++++++++++++-----------
 1 file changed, 22 insertions(+), 16 deletions(-)

diff --git a/src/routes/viewer/Table/FilterBtn.tsx b/src/routes/viewer/Table/FilterBtn.tsx
index 3466db22..f44dc8a4 100644
--- a/src/routes/viewer/Table/FilterBtn.tsx
+++ b/src/routes/viewer/Table/FilterBtn.tsx
@@ -19,6 +19,7 @@ import {
   PopoverTrigger,
 } from "@/components/ui/popover";
 import { Separator } from "@/components/ui/separator";
+import { useState } from "react";
 
 export type FilterOption<T> = {
   originalValue: T;
@@ -38,11 +39,29 @@ export function FilterBtn<TData, TValue>({
   title,
   options,
 }: Props<TData, TValue>) {
+  const [open, setOpen] = useState<boolean>(false);
   const facets = column.getFacetedUniqueValues();
   const selectedValues = new Set(column?.getFilterValue() as string[]);
 
+  function handleClearFilter(): void {
+    column?.setFilterValue(undefined);
+    setOpen(false);
+  }
+
+  function handleOptionSelect(
+    option: FilterOption<TValue>,
+    isSelected: boolean,
+  ): void {
+    if (options.length <= 2) selectedValues.clear(); // filter with radio behaviour
+    if (isSelected) selectedValues.delete(option.value); // toggle behaviour
+    else selectedValues.add(option.value);
+
+    const filterValues = Array.from(selectedValues); // get selected filter options
+    column?.setFilterValue(filterValues.length ? filterValues : undefined); // update table
+  }
+
   return (
-    <Popover>
+    <Popover open={open} onOpenChange={setOpen}>
       <PopoverTrigger asChild>
         <Button
           variant="outline"
@@ -100,20 +119,7 @@ export function FilterBtn<TData, TValue>({
                 return (
                   <CommandItem
                     key={option.value}
-                    onSelect={() => {
-                      if (isSelected) {
-                        selectedValues.delete(option.value);
-                      } else {
-                        if (options.length <= 2) {
-                          selectedValues.clear();
-                        }
-                        selectedValues.add(option.value);
-                      }
-                      const filterValues = Array.from(selectedValues);
-                      column?.setFilterValue(
-                        filterValues.length ? filterValues : undefined,
-                      );
-                    }}
+                    onSelect={() => handleOptionSelect(option, isSelected)}
                   >
                     <div
                       className={cn(
@@ -144,7 +150,7 @@ export function FilterBtn<TData, TValue>({
                 <CommandSeparator />
                 <CommandGroup>
                   <CommandItem
-                    onSelect={() => column?.setFilterValue(undefined)}
+                    onSelect={handleClearFilter}
                     className="justify-center text-center"
                   >
                     Pulisci i filtri

From 95451550ec4dbdede4be348dfd3d46a79f71d1f3 Mon Sep 17 00:00:00 2001
From: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
Date: Thu, 22 Aug 2024 17:06:38 +0200
Subject: [PATCH 3/4] fix: table crash when switching to a phase without the
 selected course (#259)

Co-authored-by: angeousta <132761637+angeousta@users.noreply.github.com>
---
 src/routes/viewer/Table/index.tsx | 30 ++++++++++++++++++++++--------
 src/routes/viewer/index.tsx       |  1 -
 2 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/src/routes/viewer/Table/index.tsx b/src/routes/viewer/Table/index.tsx
index 92ea9325..20c412bc 100644
--- a/src/routes/viewer/Table/index.tsx
+++ b/src/routes/viewer/Table/index.tsx
@@ -38,6 +38,21 @@ interface TableProps extends React.HTMLAttributes<HTMLTableElement> {
 }
 
 function makeHas(rows: StudentResult[]): Record<StudentResultKeys, boolean> {
+  if (rows.length === 0)
+    return {
+      englishCorrectAnswers: true,
+      sectionsResults: true,
+      positionAbsolute: true,
+      positionCourse: true,
+      birthDate: true,
+      result: true,
+      ofa: true,
+      enrollStatus: true,
+      enrollAllowed: true,
+      enrollCourse: true,
+      id: true,
+    };
+
   function checkKey(key: StudentResultKeys): boolean {
     const isThereAny = rows.some((r) => r[key]);
     if (!isThereAny) return false;
@@ -74,11 +89,10 @@ type ColumnVisibility = {
 };
 
 export default function Table({ table: _table, csvFilename }: TableProps) {
-  const { rows } = _table;
-  const has = makeHas(rows);
+  const has = makeHas(_table.rows);
   const [columnVisibility, setColumnVisibility] =
     useState<ColumnVisibility>(has);
-  const columns = getColumns(rows);
+  const columns = getColumns(_table.rows);
   const [pagination, setPagination] = useState<PaginationState>({
     pageSize: 15,
     pageIndex: 0,
@@ -86,7 +100,7 @@ export default function Table({ table: _table, csvFilename }: TableProps) {
 
   const [columnFilters, setColumnFilters] = useState<ColumnFiltersState>([]);
   const table = useReactTable({
-    data: rows,
+    data: _table.rows,
     columns,
     state: {
       columnVisibility,
@@ -169,12 +183,12 @@ export default function Table({ table: _table, csvFilename }: TableProps) {
               ) : (
                 <TableRow>
                   <TableCell
-                    colSpan={table.getHeaderGroups()[1].headers.length}
+                    colSpan={table.getHeaderGroups()[1]?.headers.length ?? 1}
                     className="h-24 text-center"
                   >
-                    {rows.length > 0
-                      ? "Nessuna riga trovata"
-                      : "Nessun dato disponibile"}
+                    {_table.rows.length > 0
+                      ? "La ricerca ha restituito nessun risultato"
+                      : "La tabella di questo corso non contiene righe"}
                   </TableCell>
                 </TableRow>
               )}
diff --git a/src/routes/viewer/index.tsx b/src/routes/viewer/index.tsx
index 4a8ed2ba..64fbba79 100644
--- a/src/routes/viewer/index.tsx
+++ b/src/routes/viewer/index.tsx
@@ -160,7 +160,6 @@ export const viewerRoute = new Route({
       [selectedCourse, selectedLocation, store],
     );
 
-    console.log({ ranking, selectedPhaseLink });
     return (
       <Page
         className={`flex gap-4 px-0 ${

From ecf7e50778d4146e4232473c471f09bb7f3c8281 Mon Sep 17 00:00:00 2001
From: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
Date: Thu, 22 Aug 2024 17:07:19 +0200
Subject: [PATCH 4/4] feat: add school emojis in homepage (#261)

* chore(lint): enforce noImplicitReturns and exhaustive switch blocks

* feat: add school emojis in homepage

---------

Co-authored-by: angeousta <132761637+angeousta@users.noreply.github.com>
---
 .eslintrc.cjs                        |  1 +
 src/components/custom-ui/Alert.tsx   | 32 +++++++++++++++++-----------
 src/routes/homepage/chooseSchool.tsx | 15 +++++++++++++
 tsconfig.json                        |  2 ++
 4 files changed, 38 insertions(+), 12 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 869e9ccd..43da3a12 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -10,6 +10,7 @@ module.exports = {
   parserOptions: { ecmaVersion: "latest", sourceType: "module" },
   plugins: ["react-refresh", "prettier"],
   rules: {
+    "@typescript-eslint/switch-exhaustiveness-check": "error",
     "react-refresh/only-export-components": "warn",
     "prettier/prettier": "warn",
   },
diff --git a/src/components/custom-ui/Alert.tsx b/src/components/custom-ui/Alert.tsx
index 347fe1a3..37a8394f 100644
--- a/src/components/custom-ui/Alert.tsx
+++ b/src/components/custom-ui/Alert.tsx
@@ -38,19 +38,27 @@ export default function Alert({
 }
 
 function GetIcon(level: Level) {
-  if (level === "error") return <LuAlertCircle />;
-  if (level === "warning") return <LuAlertTriangle />;
-  if (level === "info") return <LuInfo />;
-  if (level === "success") return <LuCheckCircle2 />;
+  switch (level) {
+    case "error":
+      return <LuAlertCircle />;
+    case "warning":
+      return <LuAlertTriangle />;
+    case "info":
+      return <LuInfo />;
+    case "success":
+      return <LuCheckCircle2 />;
+  }
 }
 
 const getColors = (level: Level) => {
-  if (level === "error")
-    return "bg-red-300/5 border-red-600 text-red-600 dark:bg-red-100/5 dark:border-red-300 dark:text-red-300";
-  if (level === "warning")
-    return "bg-amber-300/5 border-amber-600 text-amber-600 dark:bg-amber-100/5 dark:border-amber-200 dark:text-amber-200";
-  if (level === "info")
-    return "bg-sky-300/5 border-sky-600 text-sky-600 dark:bg-sky-100/5 dark:border-sky-200 dark:text-sky-200";
-  if (level === "success")
-    return "bg-green-300/5 border-green-600 text-green-600 dark:bg-green-100/5 dark:border-green-200 dark:text-green-200";
+  switch (level) {
+    case "error":
+      return "bg-red-300/5 border-red-600 text-red-600 dark:bg-red-100/5 dark:border-red-300 dark:text-red-300";
+    case "warning":
+      return "bg-amber-300/5 border-amber-600 text-amber-600 dark:bg-amber-100/5 dark:border-amber-200 dark:text-amber-200";
+    case "info":
+      return "bg-sky-300/5 border-sky-600 text-sky-600 dark:bg-sky-100/5 dark:border-sky-200 dark:text-sky-200";
+    case "success":
+      return "bg-green-300/5 border-green-600 text-green-600 dark:bg-green-100/5 dark:border-green-200 dark:text-green-200";
+  }
 };
diff --git a/src/routes/homepage/chooseSchool.tsx b/src/routes/homepage/chooseSchool.tsx
index 06e821a0..d82afda9 100644
--- a/src/routes/homepage/chooseSchool.tsx
+++ b/src/routes/homepage/chooseSchool.tsx
@@ -3,6 +3,20 @@ import { Button } from "@/components/ui/button";
 import { homepageRoute } from ".";
 import { ButtonGrid } from "@/components/Homepage/ButtonGrid";
 import DevSettings from "@/components/DevSettings";
+import School from "@/utils/types/data/School";
+
+function getSchoolEmoji(school: School) {
+  switch (school) {
+    case "Architettura":
+      return (<span className="mr-2 text-lg rotate-[270deg]">&#128208;</span>);
+    case "Design":
+      return (<span className="mr-2 text-lg">&#128396;&#65039;</span>);
+    case "Ingegneria":
+      return (<span className="mr-2 text-lg">&#128736;&#65039;</span>);
+    case "Urbanistica":
+      return (<span className="mr-2 text-lg">&#127969;</span>);
+  }
+}
 
 export const chooseSchoolRoute = new Route({
   getParentRoute: () => homepageRoute,
@@ -37,6 +51,7 @@ export const chooseSchoolRoute = new Route({
               className="h-full"
             >
               <Button size="card" variant="secondary" className="h-full w-full">
+                {getSchoolEmoji(school)}
                 <span className="text-lg">{school}</span>
               </Button>
             </Link>
diff --git a/tsconfig.json b/tsconfig.json
index ea0727c5..ad6b6e1c 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -15,9 +15,11 @@
 
     /* Linting */
     "strict": true,
+    "strictNullChecks": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitReturns": true,
 
     // for shadcn/ui
     "baseUrl": ".",