Grass generates underwater

[stayandwait]

When you create a new world, you see that grass was also generated underwater. This was a bug in MCPE but this no longer happens. It just happens in PocketMine now. (See photo attached.)

Steps to reproduce

1. Create a new world
2. Look for an ocean or a large lake.
3. Observe that grass was also generated underwater.

OS and versions

• PocketMine-MP: 0.14.0
• PHP: 7
• OS: Windows 10

[robske110]

ClearSkyTeam/ClearSky@17315ba

[extremeheat]

Duplicate of #3173.

@robske110 that's not much of a solution rather a hack to just "make it work"...

The generator code as a whole needs to be updated.

[robske110]

Ok, you're right if grass is under water it shouldn't be ticked

[extremeheat]

@robske110 does that commit actually fix generating dirt in seas? It seems to just block dirt from growing into grass unless I'm mistaken. I'm assuming that it just so happens to fix grass under seas (since you linked that commit) but this is something that should generally be handled in the generator.

[robske110]

Oh, I meant this issue was with growing not inital generating

[extremeheat]

Ah, I see.

[xvk-64]

I don't think this is a big issue, but it does happen with me
Also, maybe this is just a minecraft issue?

[xvk-64]

It is probably because Pocketmine generates land, then puts water on top, forgetting to turn it into dirt

[extremeheat]

@NoBakaCookies4U read the other messages. @robske110 already brung up the cause of issue