Unit tests failed after seemlingly unrelated fix for Atracsys wrapper

[atracsys-sbt]

Hi,
I'm Sylvain, employee at Atracsys LLC. As mentioned in our first communication, we have been working on fixing compatibility issues between our latest public SDK (4.5.2) and PlusLib. I'm happy to report that I have successfully compiled and tested the current version of PlusLib with various markers on both our FustionTrack (ftk) and SpryTrack (stk) devices.
However, when running PlusLib's BuildAndTest.bat, all unit tests either failed or did not run. I don't think those failures originate from my tweak to the code, however for the sake of being safe before pushing our fix, I would appreciate some help in understanding what's wrong.
Please find attached the files we modified to compare with their current version.
I don't know if it's worth mentionning, but in CMake I unchecked PLUSBUILD_INSTALL_VTK since I already have VTK9.0.1 installed on my machine and leaving it checked triggered a configuration error (Qt5 could not be found despite a correct QT5_DIR).
Regards,
S.
plus_fix_4.5.2.zip

[lassoan]

Did the test pass before the change?
Do you see errors in the event log (something about dll not found)?

Instead of attaching a zip file, please create a pull request with the proposed changes. Thank you!

[atracsys-sbt]

So, I created a fresh clone of PlusLib, configured it with PLUSBUILD_INSTALL_VTK unchecked, compiled it and ran PlusLib-bin/BuildAndTest.bat. All tests either failed or were skipped, as shown in the attached log file 1.
Then, I reconfigured PlusLib with PLUSBUILD_INSTALL_VTK checked, compiled it and ran the same script again. The tests showed mostly segmentation faults (see attached log file 2).
Keep in mind that so far I haven't touched the code, so I think my problems arise from a conflict between the VTK already installed on my computer and the one provided by PlusLib, though seemingly from the same version (9.0.1).

1 BuildTest PlusLib.txt
2 BuildTest PlusLib vtkInstalled.txt

I created the pull request with the fix we propose for the Atracsys wrapper.
Thank your for your help

[lassoan]

I could reproduce the build error using VTK9 and Qt5.

@Sunderlandkyl does the dashboard use VTK9? Have you tried to build Plus with VTK9?

I've submitted two poull requests (1 and 2), which fixes the error for me.

@Sunderlandkyl please have a look at them. Especially the IGSIO is very simplistic, as it just hardcodes setting Qt directory, regardless of VTK version.

It would be also better to understand this and avoid passing Qt manually everywhere.

[Sunderlandkyl]

Dashboard still uses VTK 8. I haven't tried building Plus with VTK 9.

It looks like Qt5_DIR was redefined in VTK8 in a number of generated CMake files.

Ex. in VTK8 vtkGUISupportQt.cmake:

if(NOT Qt5_DIR)
  set(Qt5_DIR "C:/Qt/Qt5.10.1/5.10.1/msvc2015_64/lib/cmake/Qt5")
endif()
find_package(Qt5 REQUIRED QUIET COMPONENTS Widgets)

Those calls aren't present in VTK9, so that seems to be the culprit.

[lassoan]

The fixes have been merged, so PlusLib build with VTK9 should now work well.

[atracsys-sbt]

I can confirm that I can successfully compile PlusLib with VTK9 now. That said, despite having INSTALL_VTK checked, there are still missing vtk dll's in /bin and thus the unit tests still fail.

[lassoan]

Thanks for testing. Plus official builds use VTK8. @adamrankin has implemented some VTK9 support in Plus, but apparently it is incomplete. If you want to use VTK9 then you need to copy the VTK dlls to the PlusBuild-bin\bin\Release folder manually.

@adamrankin could you fix copying/installation of VTK dlls into PlusBuild-bin\bin\Release folder?