Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Only suggest running stage apply when it would help #250

Open
ethanjli opened this issue Jun 14, 2024 · 0 comments
Open

ui: Only suggest running stage apply when it would help #250

ethanjli opened this issue Jun 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ethanjli
Copy link
Member

ethanjli commented Jun 14, 2024

The stage apply subcommand is a no-op if the pallet doesn't provide any Docker Compose apps and there are no scripts which would run as hooks for stage apply (e.g. to unmount+remount any overlays, reload the systemd daemon, etc). If the stage apply subcommand would be a no-op, then we should not suggest running it in the stdout "to apply this pallet immediately, run forklift stage apply" success message upon completion of the [dev] plt stage or stage set-next subcommands - such an instruction would be misleading, because the user would run it and expect a change which will not happen. Whenever a pallet exports files, we also should be sure to include some "you may need to restart your computer before you see all changes" text too (and if a pallet doesn't export files, we should suppress that text).

@ethanjli ethanjli added the bug Something isn't working label Jun 14, 2024
@ethanjli ethanjli self-assigned this Jun 14, 2024
@ethanjli ethanjli changed the title Only suggest running stage apply when it would help ui: Only suggest running stage apply when it would help Jun 14, 2024
@ethanjli ethanjli added this to the Backlog milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant