Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Markdig dependency #2103

Open
IsaaacD opened this issue Nov 21, 2024 · 1 comment
Open

Bumping Markdig dependency #2103

IsaaacD opened this issue Nov 21, 2024 · 1 comment

Comments

@IsaaacD
Copy link

IsaaacD commented Nov 21, 2024

Hello, I see Markdig is in Piranha.csproj but I'm wondering how I can update it?

I notice in 0.35.0 there is support for syntax like this that I would like to use in my Piranha CMS solutions [test](https://blah.org){#a-link .myclass data-lang=fr data-value="This is a value"} but that results in the curly brackets rendering as markup and not as attributes per here https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/GenericAttributesSpecs.md

I tried to manually add Markdig latest but I think I'd need to recompile Piranha when I'm just using the Nuget packages. Any help would be appreciated! Thanks

@IsaaacD
Copy link
Author

IsaaacD commented Nov 23, 2024

So I ended up downloading the repo, bumping to 0.38.0 locally. I built the repo locally and included the dll in a path in project. I updated my .csproj as such, as Markdig wasn't found for some reason without it explicitly being specified.

   <ItemGroup>
        <PackageReference Include="Markdig" Version="0.38.0" />
        <Reference Include="./Services/DLL/Piranha.dll" />
	</ItemGroup>

I will note to get the syntax I wanted to use in my initial post, I updated DefaultMarkdown.cs line 21 to this:

    public MarkdownPipeline _pipeline { get; }= new MarkdownPipelineBuilder().UseAdvancedExtensions().Build();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant