Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/quests quit [SUGGESTION] #2279

Open
agoniaprivat opened this issue Aug 17, 2024 · 5 comments
Open

/quests quit [SUGGESTION] #2279

agoniaprivat opened this issue Aug 17, 2024 · 5 comments

Comments

@agoniaprivat
Copy link

What does your feature do?

If config.yml is set to max-quests: 1, removes the requirement to type in the quest name when doing /quests quit.

How would people use it?

Would stop a lot of confusion for players, since we only allows one quest a time.

@PikaMug
Copy link
Owner

PikaMug commented Aug 18, 2024

Thanks for the suggestion. I'd consider a pull request for this, but personally I'd rather the player be absolutely certain of which quest it is they're quitting.

@agoniaprivat
Copy link
Author

Thanks for the suggestion. I'd consider a pull request for this, but personally I'd rather the player be absolutely certain of which quest it is they're quitting.

Yeah but make so they still have to type "yes" or "no" in chat 👍

Just that they have to put the quest name in the quit command, gets a little bit weird.

@HorusApl
Copy link

MyCommand (or similar plugin) can do this. Placeholders can execute themselves via a console command, so doing something like: /questadmin quit $player %quests_player_current_quest_names% would work for your purposes.

@PikaMug
Copy link
Owner

PikaMug commented Aug 19, 2024

@agoniaprivat Note that the yes/no prompt can be disabled (config.yml confim-abandon).

@HorusApl I think they want the player to run the command, or do you mean that MyCommand can take the player's /quests quit and "convert" that into a console command?

@HorusApl
Copy link

When using MyCommand, it can execute commands by the player as if they had console level perms. So anything you set there will execute even if it's a regular person. Quick example if they decide to use. $player is the internal placeholder that MyCommand uses for the player that can the command. So in this example, it will do exactly as they suggested, but with /quitquest being a shorthand of that

questsalt5: # just the ID that it needs
command: /quitquest # Command the player runs
type: RUN_CONSOLE
runcmd:

  • /questadmin quit $player %quests_player_current_quest_names%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants