Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A cloud agent connection causes the screen to go blank #11

Closed
b1conrad opened this issue Aug 31, 2021 · 5 comments
Closed

A cloud agent connection causes the screen to go blank #11

b1conrad opened this issue Aug 31, 2021 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui

Comments

@b1conrad
Copy link
Member

Matthew Hailstone created a connection between a thing (with the manifold_cloud_agent app installed) and his Evernym connect.me wallet. Not sure how far along the connection got, but now the screen goes blank when he opens up that agent.

To do: have him show the exact symptoms.

@b1conrad b1conrad added the bug Something isn't working label Aug 31, 2021
@b1conrad b1conrad self-assigned this Aug 31, 2021
@b1conrad b1conrad added the ui label Aug 31, 2021
@b1conrad
Copy link
Member Author

b1conrad commented Sep 1, 2021

When he visits this page (while logged in as himself), "Just keeps spinning and doesn’t come up."

To do: watch over his shoulder as this happens and have him try a few things.

@b1conrad
Copy link
Member Author

b1conrad commented Sep 1, 2021

The only thing suspicious on the pico side is that the crippled connection doesn't have a key their_endpoint which could produce a run-time error in the browser, since JavaScript... Never mind, it should just be undefined but perhaps that causes a problem downstream.

This would happen here and here.

The field, renamed endPoint and then (surprisingly) invitation is used as part of the id for the input field to send a basicmessage. I don't know what would happen when it is undefined. Let's simulate this...

Looks like you would see this error message in the browser console, "Uncaught TypeError: Cannot read property 'concat' of undefined" and then the page would never finish loading.

@b1conrad
Copy link
Member Author

b1conrad commented Sep 1, 2021

For Matthew's case, removed the crippled agent from his pico's list of connections by sending a well-crafted /sky/event/ to it. That solves his immediate problem.

We still need to make the page more robust.

@b1conrad b1conrad added the good first issue Good for newcomers label Sep 1, 2021
@b1conrad
Copy link
Member Author

b1conrad commented Sep 2, 2021

The issue has been resolved, for this owner, for this case. Issues have been raised in two other repositories to improve robustness.

@b1conrad
Copy link
Member Author

We will do nothing further with this issue here. When moving to the v1 pico engine (issue #9) we will not use the Manifold Cloud Agent app, because we will only support DIDComm v2 going forward.

@b1conrad b1conrad closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui
Projects
None yet
Development

No branches or pull requests

1 participant