feature: improve error handling of special binding including infiles

closes #364
PhpGt · Feb 10, 2024 · f04807a · f04807a
1 parent 3c27070
commit f04807a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Query/SqlQuery.php b/src/Query/SqlQuery.php
@@ -123,7 +123,9 @@ public function injectSpecialBindings(
 				}
 
 				if($type === "field") {
-					$replacement = "`" . $bindings[$special] . "`";
+					$words = explode(" ", $bindings[$special]);
+					$words[0] = "`" . $words[0] . "`";
+					$replacement = implode(" ", $words);
 				}
 				elseif($type === "string") {
 					$replacement = "'" . $bindings[$special] . "'";

diff --git a/test/phpunit/Query/SqlQueryTest.php b/test/phpunit/Query/SqlQueryTest.php
@@ -238,7 +238,7 @@ public function testSpecialBindingsNoAscDesc(
 		self::assertStringNotContainsString(":limit", $injectedSql);
 		self::assertStringNotContainsString(":offset", $injectedSql);
 
-		self::assertStringContainsString("order by sortColumn", $injectedSql);
+		self::assertStringContainsString("order by `sortColumn`", $injectedSql);
 		self::assertStringContainsString("limit 100", $injectedSql);
 		self::assertStringContainsString("offset 25", $injectedSql);
 	}
@@ -260,7 +260,7 @@ public function testSpecialBindingsAscDesc(
 			"offset" => 25,
 		]);
 
-		self::assertStringContainsString("order by sortColumn desc", $injectedSql);
+		self::assertStringContainsString("order by `sortColumn` desc", $injectedSql);
 	}
 
 	/**