Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arms / legs to "sign type" selection #332

Open
kchall opened this issue Jun 7, 2024 · 1 comment · May be fixed by #389
Open

add arms / legs to "sign type" selection #332

kchall opened this issue Jun 7, 2024 · 1 comment · May be fixed by #389
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kchall
Copy link
Member

kchall commented Jun 7, 2024

I'd like to allow the "Sign Type" selection to apply to hands, arms, or legs, as the Location and Movement modules do.

For example, this would be useful for a sign like SPACE v. 1 (p. 749 in the CD-ASL):
image

I'm open to suggestions about how to implement this; here is my initial suggestion.

Separate it into three tabs, for "Hands," "Arms," and "Legs." This is because the actual options for arms and legs will be different for those for hands, so trying to make any kind of universal / neutral single tab is going to be tricky.

  1. The "Hands" tab is exactly as the current set of options.

  2. The "Arms" tab has pretty much the analogous set, but with "arm" instead of "hand," and no options for "Hand configuration" relation:

image
  1. The "Legs" tab is again the same as the "Arms" tab except with "leg" instead of "arm":
image

I also think it's actually fine if a user can access and specify elements on all three tabs. This is pretty uncharted phonological territory, so I don't want to put in too many restrictions.

@kchall kchall added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2024
@kvesik
Copy link
Collaborator

kvesik commented Jun 20, 2024

Some hopefully-helpful info for getting started on this issue:

  • You'll be modifying the SignType GUI in class SigntypeSpecificationPanel
  • You'll be modifying the SignType data structure in class Signtype
  • Use QTabWidget inside the dialog-- you can see other uses of this module in class LocationOptionsSelectionPanel (via ImageTabWidget) or class PreferenceDialog.
  • Feel free to copy structure/logic from the existing SignType panel (which will become the "Hands" tab) as a reference for building the "Arms" and "Legs" tabs.

Feel free to ask questions as you go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants