Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENC] Reproducible + automatic tests #802

Open
stannam opened this issue Apr 5, 2022 · 1 comment
Open

[ENC] Reproducible + automatic tests #802

stannam opened this issue Apr 5, 2022 · 1 comment
Labels
enhancement

Comments

@stannam
Copy link
Member

stannam commented Apr 5, 2022

re: #498
PCT tests are living in ./tests
Test and update these tests to make sure they actually work.
stannam added a commit that referenced this issue Apr 5, 2022
@stannam
[UT] trying to fix discourse unit test
4eec80c 
modernized the parameter setting. It seems Discourse() accepts a dictionary of all arguments since 2016 but the test hasn't been updated :(
#802
stannam added a commit that referenced this issue Apr 5, 2022
@stannam
[UT] follow the way settings are loaded currently.
a3d2716 
#802
@stannam
Copy link
Member Author

stannam commented Apr 7, 2022

  • go through all the tests
  • need to modernize data files under ./tests/data to cover more use case scenarios (e.g., homophones behaviour, syllabified corpus, etc)
  • cf. Travis CI is not free anymore and so we need migration if we want to automate continuous testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stannam