Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Velocity's plugin manager to load Bungee plugins #1

Open
Phoenix616 opened this issue Jan 23, 2021 · 0 comments
Open

Use Velocity's plugin manager to load Bungee plugins #1

Phoenix616 opened this issue Jan 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Phoenix616
Copy link
Owner

Currently Bungee's plugin manager class is used to load and handle any Bungee plugin that gets loaded by Snap. This means that there is a clear division between Velocity and BungeeCord plugins without them knowing about each other via the plugin manager's API.

Ideally the plugins would be loaded directly by velocity's plugin manager. This would probably require some bytecode rewriting/javassist usage though to make methods like onLoad and onEnable work as well as make it compatible with what Velocity expects from plugin objects.

Another benefit of this would be to reduce the performance/memory impact that running two plugin managers could have as well as open up the possibility of registering events listeners directly with Velocity's event system instead of manually forwarding events.

Solutions should only dynamically modify classes of the plugins on load and not Velocity classes. (If necessary API should be PRd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant