Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate resource pack URLs and zip files #54

Open
Phoenix616 opened this issue Jul 17, 2021 · 0 comments
Open

Validate resource pack URLs and zip files #54

Phoenix616 opened this issue Jul 17, 2021 · 0 comments

Comments

@Phoenix616
Copy link
Owner

Is your feature request related to a problem? Please describe.

Some hosts (like mediafire, google drive, etc) will not work properly when used as pack urls which leads to errors.

Describe the solution you'd like

Validate the URL as well as that the zip has a proper resource pack setup and is not some other pack type.

Describe alternatives you've considered

A wiki page explaining the differences. Would need to be repeated to users every time though.

Additional context

The zip file check will detect non-direct download links too so that doesn't really need to be split in two. Temporary links can't really be detected so some blacklist for mediafire&co should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant