Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific Backgrounds Skills #3

Open
MrVauxs opened this issue Aug 19, 2023 · 3 comments
Open

More specific Backgrounds Skills #3

MrVauxs opened this issue Aug 19, 2023 · 3 comments
Assignees
Labels
enhancement Improve format or data structure

Comments

@MrVauxs
Copy link
Contributor

MrVauxs commented Aug 19, 2023

Currently backgrounds data only provide the total sum of what they can provide. It would be great if we can distinguish "Pick anything / from a list" from hardcoded "You are trained in X."

The basic implementation would be creating an array of objects representing available choices. The array should by default be "and", with each object being a single choice. "Trained in Occultism and any other of your choice" would become [{occultism}, {any}] in pseudo-code.

We don't need to lose our minds over "sets" of choices (yet), so no need for recursive patterns like "You are trained in either Occultism and Nature or Arcana and Religion." Let's stick it to one layer for now.

@Spappz
Copy link
Member

Spappz commented Sep 16, 2023

After discussion and addition of the Any skill, can I close this, or do you still want recursion? 🥴

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Sep 16, 2023

If we want true filtering, we will need the recursion (someone wants Performance AND Athletics, we shouldn't show backgrounds that have Performance OR Athletics). So I think we should keep this issue up for eventual inclusion.

When it comes to the website I do have an idea how to do it in the code... or at least a vague resemblance of one.

@Spappz
Copy link
Member

Spappz commented Sep 16, 2023

In that case... 😏

@Spappz Spappz transferred this issue from Pf2ools/pf2ools-data Sep 16, 2023
@Spappz Spappz added the enhancement Improve format or data structure label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve format or data structure
Projects
None yet
Development

No branches or pull requests

2 participants