Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Only update module status in Root Manager if app doesn't support WebUI #28

Open
3 tasks done
CaptainThrowback opened this issue Jul 13, 2024 · 2 comments
Open
3 tasks done
Assignees
Labels
confirmed This issue or pull request is confirmed to be done. enhancement New feature or request

Comments

@CaptainThrowback
Copy link

Description

KernelSU and APatch Manager apps both support WebUI, so the description doesn't need to include all of the status information for the module that will be available in the WebUI. Only Magisk needs this information because the Magisk apps do not support WebUI

Reason

Will make the UI cleaner and less redundant

Confirmations

  • This feature is not already implemented.
  • I have verified that this is not a duplicate feature request.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@CaptainThrowback CaptainThrowback added enhancement New feature or request not confirmed This issue or pull request is not confirmed to be done. labels Jul 13, 2024
@ThePedroo ThePedroo linked a pull request Jul 15, 2024 that will close this issue
3 tasks
@ThePedroo ThePedroo added confirmed This issue or pull request is confirmed to be done. and removed not confirmed This issue or pull request is not confirmed to be done. labels Jul 16, 2024
@ThePedroo ThePedroo self-assigned this Jul 16, 2024
@ThePedroo ThePedroo linked a pull request Aug 16, 2024 that will close this issue
2 tasks
@devnoname120
Copy link

What's the problem with modifying the description? IMO it's easier in order to see the status in a quick glance rather then having to open the webui every time.

@CaptainThrowback
Copy link
Author

What's the problem with modifying the description? IMO it's easier in order to see the status in a quick glance rather then having to open the webui every time.

The status will still be there. Talking about all the loaded modules, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue or pull request is confirmed to be done. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants