Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Redo $Home directory fix for the transfer plugin #1647

Closed
turetske opened this issue Oct 11, 2024 · 0 comments · Fixed by #1832
Closed

Refactor/Redo $Home directory fix for the transfer plugin #1647

turetske opened this issue Oct 11, 2024 · 0 comments · Fixed by #1832
Assignees
Labels
internal Internal code improvements, not user-facing plugin Issue affecting the file transfer plugin
Milestone

Comments

@turetske
Copy link
Collaborator

-- InitConfig went from not being able to fail to calling os.Exit directly. A library should never, ever exit the process. That's the job of the upper level tool. Remove all os.Exit accesses in InitConfig
-- initConfigDir is now public, meaning there's an additional step to setup the configuration. That's indicative of something else gone wrong. We should make this private again and update the tests to call InitConfig correctly
-- There's now been multiple regressions around handling of $HOME in the last year. Let's establish a unit test to get the right behavior in place ($HOME unset, $HOME set but missing, etc) to make sure we understand what we want.

@turetske turetske added internal Internal code improvements, not user-facing plugin Issue affecting the file transfer plugin labels Oct 11, 2024
@turetske turetske added this to the v7.12.0 milestone Oct 11, 2024
@turetske turetske self-assigned this Oct 11, 2024
@turetske turetske added the critical High priority for next release label Dec 2, 2024
@turetske turetske removed the critical High priority for next release label Dec 16, 2024
@turetske turetske linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal code improvements, not user-facing plugin Issue affecting the file transfer plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant