Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Server.TLSCertificate to Server.TLSCertificateChain #1574

Closed
4 of 7 tasks
matyasselmeci opened this issue Aug 23, 2024 · 0 comments · Fixed by #1825
Closed
4 of 7 tasks

Rename Server.TLSCertificate to Server.TLSCertificateChain #1574

matyasselmeci opened this issue Aug 23, 2024 · 0 comments · Fixed by #1825
Assignees
@Saartank
Labels
cache Issue relating to the cache component director Issue relating to the director component enhancement New feature or request origin Issue relating to the origin component registry Issue relating to the registry component
Milestone
v7.12.0

Comments

@matyasselmeci
Copy link
Contributor

Pelican Service:

  • Client
  • Plugin
  • Registry
  • Director
  • Origin
  • Cache
  • Other (please give the detail)

The service certificate specified in Server.TLSCertificate needs to be a full certificate chain instead of just a certificate, because clients do not generally have intermediate CAs in their CA certificate bundles. Therefore the option name TLSCertificate is misleading since it implies a single cert.

It would be nice to rename it to point out that you need a cert chain; I suggest Server.TLSCertificateChain as the new name.
@matyasselmeci matyasselmeci added enhancement New feature or request cache Issue relating to the cache component origin Issue relating to the origin component director Issue relating to the director component registry Issue relating to the registry component labels Aug 23, 2024
@matyasselmeci matyasselmeci added this to the v7.11.0 milestone Aug 23, 2024
@bbockelm bbockelm modified the milestones: v7.11.0, v7.12.0 Oct 8, 2024
@Saartank Saartank mentioned this issue Dec 12, 2024
Merged
@jhiemstrawisc jhiemstrawisc linked a pull request Dec 12, 2024 that will close this issue
Rename Server.TLSCertificate to Server.TLSCertificateChain #1825
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saartank Saartank

Labels
cache Issue relating to the cache component director Issue relating to the director component enhancement New feature or request origin Issue relating to the origin component registry Issue relating to the registry component
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging a pull request may close this issue.

Rename Server.TLSCertificate to Server.TLSCertificateChain Saartank/pelican
3 participants
@bbockelm @matyasselmeci @Saartank