Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group information not correctly escaped (OA4MP) #1494

Closed
bbockelm opened this issue Jul 18, 2024 · 0 comments · Fixed by #1800
Closed

Group information not correctly escaped (OA4MP) #1494

bbockelm opened this issue Jul 18, 2024 · 0 comments · Fixed by #1800
Assignees
Labels
bug Something isn't working origin Issue relating to the origin component
Milestone

Comments

@bbockelm
Copy link
Collaborator

When the embedded OA4MP issuer is used, it does not correctly escape the generated group path.

For example, I created the following authorization:

   - actions: ["read"]
     prefix: /groupdir/$GROUP

and COManage has me in a group named "CO:COU:Topology Contacts:members:active".

The resulting scope was:

storage.read:/groupdir/CO:COU:Topology Contacts:members:active

Spaces are significant for the scope list -- we should adjust the QDL logic so the resulting scopes are URL-escaped.

@bbockelm bbockelm added bug Something isn't working origin Issue relating to the origin component labels Jul 18, 2024
@bbockelm bbockelm added this to the v7.10.0 milestone Jul 18, 2024
brianaydemir added a commit to brianaydemir/pelicanplatform-pelican that referenced this issue Dec 6, 2024
@brianaydemir brianaydemir linked a pull request Dec 6, 2024 that will close this issue
@brianaydemir brianaydemir modified the milestones: v7.10.0, v7.12.0 Dec 10, 2024
brianaydemir added a commit that referenced this issue Dec 16, 2024
Escape user and group names in issued tokens (#1494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working origin Issue relating to the origin component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants