Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think through caching config #19

Open
cbrit opened this issue Mar 10, 2022 · 0 comments
Open

Think through caching config #19

cbrit opened this issue Mar 10, 2022 · 0 comments

Comments

@cbrit
Copy link
Member

cbrit commented Mar 10, 2022

It's been unofficially decided ocular doesn't really need a cli because it's redundant with lens. However, one really useful thing about the lens cli is that it caches chain registry config data locally. Ocular should probably have this capability in case the registry becomes inaccessible such as during a Github outage.

Ocular could cache config in a local file when a chain client is first constructed so that future construction of clients for that chain wouldn't need to make calls to the registry. We may need to think about some kind of policy around making sure the config doesn't get stale like if endpoints are updated in the registry. Alternatively we could leave this to the user. Perhaps some kind of way to configure the behavior at client construction time (a method like ChainClient::new_with_options()?). This issue for starting a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant