From 33288c0d2fbfc9d8a2019da5c16289de34893300 Mon Sep 17 00:00:00 2001 From: Esteban Giraldo Date: Mon, 18 Nov 2024 11:37:19 -0500 Subject: [PATCH] fix: typos and trailing comma --- docs/001-custom-features.md | 6 +++--- edx_sga/tests/test_utils.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/001-custom-features.md b/docs/001-custom-features.md index 1f8e7ede..2440941f 100644 --- a/docs/001-custom-features.md +++ b/docs/001-custom-features.md @@ -37,12 +37,12 @@ This feature allows CCX coaches (ccx_coach in the course access role model) and ### Context The SGA Xblock in its upstream repository approaches the storage capability by relaying on the Django's default storage -that is defined in the edx platform. Tehre's also a feature where the storage backend to be used can be defined via +that is defined in the edx platform. There's also a feature where the storage backend to be used can be defined via platform settings. For our fork, this feature adds the capability to define a site-aware backend via site configurations. ### Feature -To define a desire backend shall follow the following format by defining the storage class and it's kwargs. +To define a d backend shall follow the following format by defining the storage class and its kwargs. As an example, below you will be find de Site Configuration definition to use an AWS S3 bucket: "SGA_STORAGE_SETTINGS": { @@ -56,4 +56,4 @@ As an example, below you will be find de Site Configuration definition to use an } Once it has been done, the SGA xblocks for the given site will manage the media objects with the defined storage backend. -If no settings are defined, the Xblock would use the default Django storage +If no settings are defined, the Xblock will use the default Django storage diff --git a/edx_sga/tests/test_utils.py b/edx_sga/tests/test_utils.py index a3195820..b72dcece 100644 --- a/edx_sga/tests/test_utils.py +++ b/edx_sga/tests/test_utils.py @@ -51,7 +51,7 @@ def test_get_default_storage_with_settings_override(mock_configuration_helpers): "region_name": "us-east-1" } } - } + }, ) storage = get_default_storage() assert storage.__class__ == S3Boto3Storage