Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7-bit serial support on Teensy 4 sets top bit #664

Open
ssilverman opened this issue Nov 17, 2022 · 4 comments · May be fixed by #665
Open

7-bit serial support on Teensy 4 sets top bit #664

ssilverman opened this issue Nov 17, 2022 · 4 comments · May be fixed by #665

Comments

@ssilverman
Copy link
Contributor

ssilverman commented Nov 17, 2022 •
edited
Loading

Received 7-bit serial data on Teensy 4 sometimes has the top bit set.

A PR is forthcoming...
@ssilverman ssilverman linked a pull request Nov 17, 2022 that will close this issue
Draft
@ssilverman
Copy link
Contributor Author

It turns out that without the fix, the transmit properly sends 7-bit data, but receive still sometimes sets the 8th bit high. I need to explore more...

@ssilverman
Copy link
Contributor Author

ssilverman commented Nov 18, 2022 •
edited
Loading

See: #665 (comment)

The last bit in the stream is the parity bit, and is also the top bit in the byte.

@ssilverman ssilverman changed the title Missing 7-bit serial support on Teensy 4 7-bit serial support on Teensy 4 sets top bit Nov 18, 2022
@ssilverman
Copy link
Contributor Author

I believe the issue also appears in teensy3 serial. I updated the PR with a second commit to fix that too.

@PaulStoffregen
Copy link
Owner

I want to spend some more time (not merging just yet) looking at this and how Arduino's boards are handling parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 7-bit support for teensy4 and teensy3 ssilverman/cores
2 participants
@PaulStoffregen @ssilverman