Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic: Probability #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LorenzoLuccioli
Copy link
Contributor

@LorenzoLuccioli LorenzoLuccioli commented Sep 23, 2024

Add the file Topics.Probability with some simple exercises about probability theory, independence of sets, definition of conditional probability and Bayes' theorem.

@RemyDegenne
Copy link

You should also add the file to the list of topics files at the bottom of 03Forall.lean (in both exercises and solutions).

Copy link
Contributor

@pitmonticone pitmonticone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few minor typos. You can directly commit the suggested changes.

GlimpseOfLean/Exercises/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Exercises/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
Copy link
Contributor

@pitmonticone pitmonticone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good to me.

Thank you @LorenzoLuccioli for the PR and @RemyDegenne for the review comment!

@fpvandoorn
Copy link
Contributor

For future reference: the script mk_exercises.py generates the exercise files from the solution files (if the solution file is properly marked with -- sorry comments)

@fpvandoorn
Copy link
Contributor

The new probability file should probably get -- sorry commands so that the script also works for it.

@PatrickMassot
Copy link
Owner

Thanks! Indeed it needs to be adapted to work with mk_exercises.

GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
GlimpseOfLean/Solutions/Topics/Probability.lean Outdated Show resolved Hide resolved
@pitmonticone
Copy link
Contributor

@LorenzoLuccioli You just need to commit the suggested changes and run:

python3 mk_exercises.py

@pitmonticone
Copy link
Contributor

Ok, now it looks good to me.

Thank you again @LorenzoLuccioli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants